Merged
Conversation
Contributor
Author
|
/CC @nodejs/testing @nodejs/async_hooks |
Contributor
|
The commit message could be a little more descriptive... |
cjihrig
approved these changes
Nov 2, 2017
Member
|
@refack could you add a link to the |
MylesBorins
approved these changes
Nov 2, 2017
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM with the nits mentioned above being taken care of
- more descriptive commit message
- link included to issue
I'd like to see this land asap
`parallel/test-async-wrap-uncaughtexception.js` has become flaky. At this time investigating the cause is still on going, but this issue become has prevalent. In order to restore CI status to be relevant, this marks the test as explicitly FLAKY. PR-URL: nodejs#16694 Refs: nodejs#16210 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
refack
force-pushed
the
test-async-wrap-uncaughtexception-flaky
branch
from
3a75e89 to
75095d7
Compare
Contributor
Author
|
Landed with nits addressed |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
`parallel/test-async-wrap-uncaughtexception.js` has become flaky. At this time investigating the cause is still on going, but this issue become has prevalent. In order to restore CI status to be relevant, this marks the test as explicitly FLAKY. PR-URL: nodejs#16694 Refs: nodejs#16210 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
Member
|
Marking as don't land, because I basically just landed both in #16702 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #16210
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test